codec(ticdc): simple protocol support encode dml event #10112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
3AceShowHand
force-pushed
the
simple-dml-event
branch
from
4241600 to
0aae4fd
Compare
ti-chi-bot
bot
added
size/XL
ti-chi-bot
bot
added
size/XXL
ti-chi-bot
bot
added
the
needs-rebase
ti-chi-bot
bot
removed
the
needs-rebase
asddongmen
reviewed
Nov 23, 2023
asddongmen
reviewed
Nov 23, 2023
asddongmen
reviewed
Nov 23, 2023
3AceShowHand
force-pushed
the
simple-dml-event
branch
from
a5642d2 to
6e86990
Compare
|
/test cdc-integration-storage-test |
|
/test dm-integration-test |
|
/retest |
cdc/owner/ddl_manager.go
Outdated
| @@ -208,7 +208,7 @@ func (m *ddlManager) tick( | |||
| return nil, nil, err | |||
| } | |||
| if !ok { | |||
| return nil, nil, nil | |||
| return nil, m.barrier(), nil | |||
There was a problem hiding this comment.
Why return an empty barrier here?
There was a problem hiding this comment.
return nil cause the panic, and the barrier is initialized as empty I think.
Co-authored-by: CharlesCheung <[email protected]>
CharlesCheung96
approved these changes
Nov 30, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, CharlesCheung96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
|
/test cdc-integration-pulsar-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9902, close #10186, close #10185,
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note